client.then - Code Metrics - Inspection of "only use segwit for change addresses for now" - blocktrail/blocktrail-sdk-nodejs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#79)

by Ruben de

created 2017-11-22 13:49 UTC

client.then A

↳ Parent: client.then

Complexity

Conditions	1
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
nc	4
dl	0
loc	62
rs	9.4743
c	1
b	0
f	0
nop	0

How to fix Long Method

var _ = require('lodash');
var blocktrail = require('../');
var q = require('q');
var crypto = require('crypto');
var async = require('async');
var bitcoin = require('bitcoinjs-lib');
var bip39 = require("bip39");

/**
 * @type APIClient
 */
var client = blocktrail.BlocktrailSDK({
    apiKey : process.env.BLOCKTRAIL_SDK_APIKEY || "EXAMPLE_BLOCKTRAIL_SDK_NODEJS_APIKEY",
    apiSecret : process.env.BLOCKTRAIL_SDK_APISECRET || "EXAMPLE_BLOCKTRAIL_SDK_NODEJS_APISECRET",
    testnet : true
});

// aggregate TXs will try to have N outputs
var SPLITNOUTS = 5;
// don't go below MINVALUE when trying to send
var MINVALUE = 10000;
// don't glo below MINSPLITVALUE for outputs (nouts will be rounded down to match this)
var MINSPLITVALUE = 10000;
var ONEBTC = 1e8;

client.initWallet({
    identifier: "unittest-transaction",
    password: "password"
})
    .then(function(wallet) {
        // @DBEUG
        // return wallet.utxos().then(function(utxos) {
        //     console.log(utxos);
        // });

        return wallet.maxSpendable(false).then(function(maxSpendable) {
            console.log(maxSpendable);


            // get the address to aggregate the coins to
            var addr = wallet.getAddressByPath("M/9999'/0/0");
            console.log(addr);

            var splitSend = function(value) {
                var pay = [];
                var splitValue = Math.max(MINSPLITVALUE, Math.floor(value / SPLITNOUTS)).toFixed(0);
                var nouts = Math.floor(value / splitValue);

                for (var i = 0; i < nouts; i++) {
                    pay.push({address: addr, value: splitValue});
                }

                return wallet.pay(pay, null, false, false, blocktrail.Wallet.FEE_STRATEGY_MIN_RELAY_FEE, false, {allowZeroConfSelf: false}).then(function(txId) {
                    console.log(txId);

                });
            };

            // start at 20 BTC, * 0.5 every time we can't send such a large amount anymore
            var value = 20 * ONEBTC;
            // track retries
            var retries = 0;

            var keepSpending = function() {
                return wallet.getBalance().then(function(b) {
                    console.log(b);


                    // do a split send
                    return splitSend(Math.min(b[0], value))
                        .then(function() {
                            // keep sending for as long as possible
                            return keepSpending()
                                .then(function() {
                                    // reset retries on success
                                    retries = 0;
                                });
                        }, function(e) {
                            console.error(e.message || e);

                            // if TX is too big (or MrSign times out cuz TX is too big to sign)
                            if (e.message.match(/too big/) || e.message.match(/MrSign/)) {
                                // if value reaches <= MINVALUE then we're done(ish)
                                if (value <= MINVALUE) {
                                    retries++;

                                    // retry 3 more times, otherwise done
                                    if (retries >= 3) {
                                        throw new Error("DONE");
                                    }

                                    // keep trying
                                    return keepSpending();
                                } else {
                                    // halve the value and try again
                                    value *= 0.5;
                                    console.log('too big, new value:', blocktrail.toBTC(value));


                                    return keepSpending();
                                }
                            } else if (e.message.match(/too low/)) {
                                // halve the value and try again
                                value *= 0.5;
                                console.log('too big, new value:', blocktrail.toBTC(value));

                                return keepSpending();
                            } else if (e.message.match(/All usable unspent/)) {
                                // halve the value and try again, but with a timeout
                                value *= 0.5;
                                console.log('too big, new value:', blocktrail.toBTC(value));

                                var deferred = q.defer();

                                setTimeout(function() {
                                    deferred.resolve();
                                }, 11000);

                                return deferred.promise.then(function() {
                                    return keepSpending();
                                });
                            }

                            throw e;
                        });
                });
            };

            return keepSpending();
        });
    })
    .catch(function(e) {
        console.error(e);
    });


1			var _ = require('lodash');
2			var blocktrail = require('../');
3			var q = require('q');
4			var crypto = require('crypto');
5			var async = require('async');
6			var bitcoin = require('bitcoinjs-lib');
7			var bip39 = require("bip39");
8
9			/**
10			* @type APIClient
11			*/
12			var client = blocktrail.BlocktrailSDK({
13			apiKey : process.env.BLOCKTRAIL_SDK_APIKEY \|\| "EXAMPLE_BLOCKTRAIL_SDK_NODEJS_APIKEY",
14			apiSecret : process.env.BLOCKTRAIL_SDK_APISECRET \|\| "EXAMPLE_BLOCKTRAIL_SDK_NODEJS_APISECRET",
15			testnet : true
16			});
17
18			// aggregate TXs will try to have N outputs
19			var SPLITNOUTS = 5;
20			// don't go below MINVALUE when trying to send
21			var MINVALUE = 10000;
22			// don't glo below MINSPLITVALUE for outputs (nouts will be rounded down to match this)
23			var MINSPLITVALUE = 10000;
24			var ONEBTC = 1e8;
25
26			client.initWallet({
27			identifier: "unittest-transaction",
28			password: "password"
29			})
30			.then(function(wallet) {
31			// @DBEUG
32			// return wallet.utxos().then(function(utxos) {
33			// console.log(utxos);
34			// });
35
36			return wallet.maxSpendable(false).then(function(maxSpendable) {
37			console.log(maxSpendable);
			0 ignored issues – show Debugging Code introduced 2017-11-21 16:05 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
38
39			// get the address to aggregate the coins to
40			var addr = wallet.getAddressByPath("M/9999'/0/0");
41			console.log(addr);
42
43			var splitSend = function(value) {
44			var pay = [];
45			var splitValue = Math.max(MINSPLITVALUE, Math.floor(value / SPLITNOUTS)).toFixed(0);
46			var nouts = Math.floor(value / splitValue);
47
48			for (var i = 0; i < nouts; i++) {
49			pay.push({address: addr, value: splitValue});
50			}
51
52			return wallet.pay(pay, null, false, false, blocktrail.Wallet.FEE_STRATEGY_MIN_RELAY_FEE, false, {allowZeroConfSelf: false}).then(function(txId) {
53			console.log(txId);
			0 ignored issues – show Debugging Code introduced 2017-11-21 16:05 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
54			});
55			};
56
57			// start at 20 BTC, * 0.5 every time we can't send such a large amount anymore
58			var value = 20 * ONEBTC;
59			// track retries
60			var retries = 0;
61
62			var keepSpending = function() {
63			return wallet.getBalance().then(function(b) {
64			console.log(b);
			0 ignored issues – show Debugging Code introduced 2017-11-21 16:05 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
65
66			// do a split send
67			return splitSend(Math.min(b[0], value))
68			.then(function() {
69			// keep sending for as long as possible
70			return keepSpending()
71			.then(function() {
72			// reset retries on success
73			retries = 0;
74			});
75			}, function(e) {
76			console.error(e.message \|\| e);
77
78			// if TX is too big (or MrSign times out cuz TX is too big to sign)
79			if (e.message.match(/too big/) \|\| e.message.match(/MrSign/)) {
80			// if value reaches <= MINVALUE then we're done(ish)
81			if (value <= MINVALUE) {
82			retries++;
83
84			// retry 3 more times, otherwise done
85			if (retries >= 3) {
86			throw new Error("DONE");
87			}
88
89			// keep trying
90			return keepSpending();
91			} else {
92			// halve the value and try again
93			value *= 0.5;
94			console.log('too big, new value:', blocktrail.toBTC(value));
			0 ignored issues – show Debugging Code introduced 2017-11-21 16:05 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
95
96			return keepSpending();
97			}
98			} else if (e.message.match(/too low/)) {
99			// halve the value and try again
100			value *= 0.5;
101			console.log('too big, new value:', blocktrail.toBTC(value));
102
103			return keepSpending();
104			} else if (e.message.match(/All usable unspent/)) {
105			// halve the value and try again, but with a timeout
106			value *= 0.5;
107			console.log('too big, new value:', blocktrail.toBTC(value));
108
109			var deferred = q.defer();
110
111			setTimeout(function() {
112			deferred.resolve();
113			}, 11000);
114
115			return deferred.promise.then(function() {
116			return keepSpending();
117			});
118			}
119
120			throw e;
121			});
122			});
123			};
124
125			return keepSpending();
126			});
127			})
128			.catch(function(e) {
129			console.error(e);
130			});
131

blocktrail / blocktrail-sdk-nodejs

Pull Request — master (#79)

client.then A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like